-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808
External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. spring-cloud-azure-autoconfigure |
…s out with deprecation APIs
…h deprecation APIs
org.springframework.boot:spring-boot;3.0.0-RC1 | ||
org.springframework.data:spring-data-commons;3.0.0-RC1 | ||
org.springframework.data:spring-data-mongodb;4.0.0-RC1 | ||
org.springframework.data:spring-data-redis;3.0.0-RC1 | ||
org.springframework.experimental:spring-aot;0.11.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this now? Or leave it until we start working on the aot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be removed until we start developing the new AOT support, the current native configuration module will use this dependency.
@@ -103,7 +103,7 @@ public List<OAuth2TokenValidator<Jwt>> createDefaultValidator(AadAuthenticationP | |||
* Default security configuration of the resource server, user can write another configuration bean to override it. | |||
*/ | |||
@EnableWebSecurity | |||
@EnableGlobalMethodSecurity(prePostEnabled = true) | |||
@EnableMethodSecurity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why making this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The annotation @EnableGlobalMethodSecurity is marked as a deprecated API since the RC1 version, see https://github.com/spring-projects/spring-security/blob/6.0.0-RC1/config/src/main/java/org/springframework/security/config/annotation/method/configuration/EnableGlobalMethodSecurity.java
@moarychan, seems like some jobs in the core-ci and jdbc-ci failed, is this expected? |
…emetry-sdk-logs and opentelemetry-sdk-extension-autoconfigure because they are not included in the opentelemetry-bom
jdbc-ci pipelines passed. @saragluna could you help check whether we can ignore those failures? |
@moarychan seems like there are two modules are affected:
Could you help check whether we can make the |
The amqp tests also failed in this PR, please help take a look #31730. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade the dependencies to align with Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1.
Changes:
azure-core
on deprecated API usage(com.azure.core.implementation.logging.DefaultLogger).sync_external_dependencies.py
to support more use cases.